Skip to content

fix(entry_resolver): search recursively for entry module #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2016

Conversation

juristr
Copy link
Contributor

@juristr juristr commented Dec 22, 2016

The entry module wasn't detected properly when the standard bootstrapping instruction

platformBrowserDynamic().bootstrapModule(AppModule);

is changed to something like

platformBrowserDynamic().bootstrapModule(AppModule).then(() => console.log('...'));

Then the CLI doesn't execute the build with the error mentioned in #2887.

AFAIK, the problem was that in the 2nd case, the bootstrapModule instruction is nested more deep in the AST wherefore it wasn't found. I changed it to search recursively which fixes the issue.

Fixes #2887

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--aot fails to build with no entryModule error
3 participants