adds server-config option to ng serve #3661
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
kdimatteo
force-pushed
the
feature/adds-expressJS-setup
branch
5 times, most recently
from
b735a2e to
1f3c46c
Compare
remove commented lines
kdimatteo
force-pushed
the
feature/adds-expressJS-setup
branch
from
1f3c46c to
39b75db
Compare
victormejia
reviewed
Dec 22, 2016
| Webpack dev server allows us to modify the ExpressJS `app` object using the `setup` method. | ||
| We do this by passing a file to `--server-config` | ||
|
|
||
| We create a file next to the projects `package.json` called `server.conf.js` with the content |
victormejia
reviewed
Dec 22, 2016
|
|
||
|
|
||
| export default function() { | ||
| // const app = express(); |
|
This isn't something we're looking to add. The proxy configuration already let's you do something similar. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat (webpack-dev-server): add cli option for static mocks
Add the option to serve static JSON mocks when discreet server is not necessary or available