feat(formatting): adding editor config, adding eslint and tslint #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackarychapple
changed the title
| install: function(options){} | ||
|
|
||
| install: function(options) {}// eslint-disable-line no-unused-vars |
There was a problem hiding this comment.
if you name the argument _ would it still complain?
Or remove the argument.
There was a problem hiding this comment.
yes it still complains, I did not remove the argument because of the giant warning comment block. If you feel its safe to remove I will.
|
LGTM. We should enforce this in Travis too, but this can be done in the next CL. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(formatting): adding editor config, adding eslint and tslint
code formatting was not implemented for the anglar-cli project itself. adding eslint and tslint, did initial formatting for eslint