feat(deploy): add custom-domain support for gh-pages deployment (#1781) #3391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Creates CNAME file if --custom-domain flag is provided. addresses (#1781) This commit
|
CLAs look good, thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature for (#1781)
This PR adds the new
--custom-domainflag to thegithub-pages:deploycommand to create a CNAME file to support Github Pages custom domains.I am looking for some guidance on the testing for this since
github-pages-deploy.spec.jsdoesn't contain any logic/acceptance criteria to ensure that certain files are created. It is only checkinggit related commands and http requests.
Currently the similar method
createNotFoundPage()is not tested either. Either way, all tests and linting pass. I also have some spare domains and tested that Github's DNS picks the CNAME up with a new branch correctly.