-
Notifications
You must be signed in to change notification settings - Fork 12k
expose ngc i18n options #3098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
expose ngc i18n options #3098
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ef62e6a
Expose ngc i18n options
tdesmet ee821ff
Add e2e test for i18n support
tdesmet 0b4b621
Fix tslint errors
tdesmet 5d4bfe0
Remove meaning
tdesmet 935787a
Add negative test
tdesmet b3b6707
Merge remote-tracking branch 'upstream/master' into i18n-options
tdesmet 5b45739
Merge branch 'master' into i18n-options
tdesmet 33be929
Remove .orig artifacts from kdiff3
tdesmet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import {ng} from '../../utils/process'; | ||
import {expectFileToMatch, writeFile, createDir, appendToFile} from '../../utils/fs'; | ||
|
||
export default function() { | ||
return Promise.resolve() | ||
.then(() => createDir('src/locale')) | ||
.then(() => writeFile('src/locale/messages.fr.xlf', ` | ||
<?xml version="1.0" encoding="UTF-8" ?> | ||
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2"> | ||
<file source-language="en" datatype="plaintext" original="ng2.template"> | ||
<body> | ||
<trans-unit id="8def8481e91291a52f9baa31cbdb313e6a6ca02b" datatype="html"> | ||
<source>Hello i18n!</source> | ||
<target>Bonjour i18n!</target> | ||
<note priority="1" from="description">An introduction header for this sample</note> | ||
</trans-unit> | ||
</body> | ||
</file> | ||
</xliff>`)) | ||
.then(() => appendToFile('src/app/app.component.html', | ||
'<h1 i18n="An introduction header for this sample">Hello i18n!</h1>')) | ||
.then(() => ng('build', '--aot', '--i18n-file', 'src/locale/messages.fr.xlf', '--i18n-format', | ||
'xlf', '--locale', 'fr')) | ||
.then(() => expectFileToMatch('dist/main.bundle.js', /Bonjour i18n!/)); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a negative test? Running
ng build
on the same project without--locale
should not containBonjour i18n
.