Skip to content

Correct forkChecker ats config option to speed up reloads #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2016

Conversation

texel
Copy link
Contributor

@texel texel commented Nov 3, 2016

The option for awesome-typescript-loader to fork the type checker is forkChecker, not useForkChecker. This change forks the type checker, and drastically lowers reload times (from ~4sec to ~1.5sec on a new project on my machine).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@texel
Copy link
Contributor Author

texel commented Nov 3, 2016

@googlebot CLA signed under the corporation "Distributed Creation". Email address in these commits should be covered. Thanks!

@Meligy
Copy link
Contributor

Meligy commented Nov 4, 2016

Weird. It's still not happening.

I'm not sure whether it's taking your git commit commit author email or your github profile email (which is public from what I can see).

@filipesilva
Copy link
Contributor

Restarted travis, and trying to get someone to look at the CLA.

@hansl hansl merged commit a987cf5 into angular:master Nov 4, 2016
@maximedupre
Copy link

Will this be available in the next version (1.0.0-beta.19-4/1.0.0-beta.20)?

@hansl
Copy link
Contributor

hansl commented Nov 6, 2016

Yes.

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants