fix(@angular/ssr): enhance dynamic route matching for better performance and accuracy #29461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
matchers
branch
2 times, most recently
from
0d2acbb to
6b9be13
Compare
alan-agius4
added
the
action: review
alan-agius4
added
the
target: patch
alan-agius4
force-pushed
the
matchers
branch
6 times, most recently
from
76a7d9d to
b01f492
Compare
dgp1130
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
It seems like there's a few small breaking changes here. I know this feature is still dev preview, so we can probably ship this and I'm happy to defer to your judgement. I just want to make sure we're thinking about the impact here and making that decision intentionally.
…nce and accuracy Updated route matching logic to prioritize closest matches, improving the accuracy of dynamic route resolution. Also we optimized performance by eliminating unnecessary recursive checks, reducing overhead during route matching. Closes angular#29452
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated route matching logic to prioritize closest matches, improving the accuracy of dynamic route resolution. Also we optimized performance by eliminating unnecessary recursive checks, reducing overhead during route matching.
Closes #29452