Skip to content

Fix Protractor test so 'ng e2e' succeeds after 'ng new' #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2016

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Mar 2, 2016

Fix Protractor test so ng e2e succeeds after ng new.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mraible
Copy link
Contributor Author

mraible commented Mar 2, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@hansl
Copy link
Contributor

hansl commented Mar 2, 2016

This seems to be that the matcher is using CamelCase of the AppName, rather than the kebab-case. Have you tried using htmlComponentName instead?

I would side on safety here and use the proper selector 😄

@filipesilva
Copy link
Contributor

Yeah it should be htmlComponentName, at the time I must have used a simple project name and thus didn't notice the difference.

Good catch @mraible!

@mraible
Copy link
Contributor Author

mraible commented Mar 3, 2016

I changed it to htmlComponentName and confirmed this works.

@jkuri
Copy link
Contributor

jkuri commented Mar 3, 2016

lgtm

@jkuri
Copy link
Contributor

jkuri commented Mar 3, 2016

Please squash this two commits into one. If you need a help doing that just say.

@mraible
Copy link
Contributor Author

mraible commented Mar 3, 2016

@jkuri - I found an answer on Stack Overflow on how to do it, but I'm not sure of the command. Is it something like this?

git reset --soft HEAD~2 &&
git commit

@jkuri
Copy link
Contributor

jkuri commented Mar 3, 2016

git rebase -i HEAD~2
git push origin e2e-protractor-fix -f 

And please rename the commit to something like
fix(tests): Fix Protractor test so 'ng e2e' succeeds after 'ng new'

Thanks.

@mraible mraible force-pushed the e2e-protractor-fix branch from 1c8432b to 17cb4da Compare March 3, 2016 16:25
@mraible
Copy link
Contributor Author

mraible commented Mar 3, 2016

@jkuri Thanks for the assistance.

@jkuri
Copy link
Contributor

jkuri commented Mar 3, 2016

@mraible np, thank you for the fix.

@jkuri jkuri merged commit 17cb4da into angular:master Mar 3, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants