Skip to content

refactor(@angular-devkit/build-angular): remove workaround for handle options requests #23725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2022
Merged

refactor(@angular-devkit/build-angular): remove workaround for handle options requests #23725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions packages/angular_devkit/build_angular/src/webpack/configs/dev-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,26 +92,6 @@ export async function getDevServerConfig(
publicPath: servePath,
stats: false,
},
setupMiddlewares: (middlewares, _devServer) => {
// Temporary workaround for https://github.com/webpack/webpack-dev-server/issues/4180
middlewares.push({
name: 'options-request-response',
path: '*',
middleware: (req: Request, res: Response, next: NextFunction) => {
if (req.method === 'OPTIONS') {
res.statusCode = 204;
res.setHeader('Content-Length', 0);
res.end();

return;
}

next();
},
});

return middlewares;
},
liveReload,
hot: hmr && !liveReload ? 'only' : hmr,
proxy: await addProxyConfig(root, proxyConfig),
Expand Down