Skip to content

chore: update angular to rc7 #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2016
Merged

chore: update angular to rc7 #2084

merged 1 commit into from
Sep 13, 2016

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Sep 13, 2016

No description provided.

@@ -44,9 +44,9 @@
"homepage": "https://github.com/angular/angular-cli",
"dependencies": {
"@angular-cli/ast-tools": "^1.0.0",
"@angular/compiler": "^2.0.0-rc.6",
"@angular/compiler": "^2.0.0-rc.7",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that CLI itself uses a ^ dependency, while the generated blueprint uses a fixed dependency. I like that letter fixed dependency, mostly because of so many past incidents. I am curious whether the floating dependency at the top level CLI package file could make it possible for bugs to slip past undetected, for example if a build were to be run in a situation where CLI and its test suite etc. are using version N+1 but the generated program will use version N.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think the compiler isn't used per se right now, but will be soon for AoT.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used for lazy loading.

@filipesilva
Copy link
Contributor

router needs rc.3 but otherwise lgtm.

@Brocco Brocco merged commit 9d255ca into angular:master Sep 13, 2016
@Brocco Brocco deleted the rc7 branch September 13, 2016 17:02
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants