Skip to content

fix(@angular-devkit/build-angular): correctly resolve symlinked global styles entrypoints #19713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2021
Merged

fix(@angular-devkit/build-angular): correctly resolve symlinked global styles entrypoints #19713

merged 1 commit into from
Jan 6, 2021

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jan 5, 2021

With this change we resolve the global stylesheet entrypoint path to use the realpath instead of the symlink path.

Fixes #3500

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release preserve commits labels Jan 5, 2021
@alan-agius4 alan-agius4 requested a review from clydin January 5, 2021 08:56
@google-cla google-cla bot added the cla: yes label Jan 5, 2021
…l styles entrypoints

With this change we resolve the global stylesheet entrypoint path to use the realpath instead of the symlink path.

Fixes #3500
@alan-agius4 alan-agius4 requested a review from clydin January 5, 2021 20:04
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2021
@filipesilva filipesilva merged commit 1df8a3d into angular:master Jan 6, 2021
@alan-agius4 alan-agius4 deleted the symlink-global-scss branch January 6, 2021 12:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stylesheet from (npm) linked package not loaded correctly
3 participants