Skip to content

bug(): Inject missing providers for routes #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Feb 5, 2016

CORE_DIRECTIVES from angular2/core was missing when using ngIf & ngFor

CORE_DIRECTIVES from angular2/core was missing when using ngIf & ngFor
@IgorMinar
Copy link
Contributor

This is not necessary because CORE_DIRECTIVES are added to PLATFORM_DIRECTIVES which are available by default. am I missing anything?

@Brocco
Copy link
Contributor Author

Brocco commented Feb 5, 2016

It was throwing an error when I was running ng-test locally on that branch, adding this fixed the tests running after adding routes

@Brocco Brocco closed this Feb 5, 2016
@Brocco Brocco deleted the fix-route-blueprints branch February 5, 2016 22:13
@filipesilva
Copy link
Contributor

It's probably due to the need to configure default providers for tests according to platform. I believe the angular 2 changelog has some information about that in beta 2.

@Brocco
Copy link
Contributor Author

Brocco commented Feb 6, 2016

@filipesilva I was able to find the docs you were referring to, but for now master is still @ beta 0

@filipesilva
Copy link
Contributor

Perhaps we should recheck this after updating.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants