Skip to content

feat: Implementation of flag to install Angular Material on new or init #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

feat: Implementation of flag to install Angular Material on new or init #1038

wants to merge 9 commits into from

Conversation

marc-sensenich
Copy link
Contributor

@marc-sensenich marc-sensenich commented Jun 7, 2016

Added --material flag onto the new and init features for the core setup of Angular Material

fixes #884

…`init`

This features adds a `--material` flag to the `new` and `init` options. This
streamlines the process of the adding of Angular Material to a new project
This reverts commit c16c552.
This reverts commit 16a8d6a.
…`init`

This features adds a `--material` flag to the `new` and `init` options. This
streamlines the process of the adding of Angular Material to a new project
@metric152
Copy link

this is pretty cool. nice feature add.

@filipesilva
Copy link
Contributor

@hansl can you have a look?

@JohannesHoppe
Copy link
Contributor

Great idea. 👍
But I tried this out and I don't see a big benefit (for now).

According to the "Getting Started Guide" (https://github.com/angular/material2/blob/master/GETTING_STARTED.md) only step 1 to 3 are done.

There are more steps to do:

  • I still need to install the componentes by hand (eg. npm install --save @angular2-material/{button,card}
  • vendorNpmFiles copies only *.js files, it should copy everything
  • Main file for the packages are not configured.
    materialPkgs.forEach((pkg) => { packages[@angular2-material/${pkg}] = {main: ${pkg}.js}; });

For the sake of simplicity I would install all components by default...

@JohannesHoppe
Copy link
Contributor

@filipesilva
Copy link
Contributor

Closed as this PR was made obsolete by #1455.

@marc-sensenich marc-sensenich deleted the angular2-material-flag branch November 11, 2016 01:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smooth integration of angular2-material
4 participants