Skip to content

typings folder missing upon git clone & npm install bug #431

Closed
@sashafirsov

Description

@sashafirsov
  1. OS. Windows 10, Mac OSX El Capitan

  2. Versions.
    angular-cli: 0.0.31
    node: 5.9.1
    os: win32 x64

    npm --version
    

    3.7.3
    npm info angular-cli
    { name: 'angular-cli',
    time:
    { modified: '2016-04-11T18:20:32.677Z',
    created: '2014-10-07T04:34:38.078Z',
    '1.0.0': '2014-10-07T04:34:38.078Z',
    '0.0.0': '2014-10-11T11:38:24.914Z',
    '0.0.1': '2015-08-03T17:12:04.553Z',
    '0.0.2': '2015-10-18T17:46:40.146Z',
    '0.0.3': '2015-10-18T21:42:52.445Z',
    '0.0.4': '2015-10-19T01:14:13.216Z',
    '0.0.5': '2015-10-19T09:14:01.712Z',
    '0.0.6': '2015-10-19T09:36:51.644Z',
    '0.0.7': '2015-10-19T11:48:24.233Z',
    '0.0.8': '2015-10-19T11:51:59.318Z',
    '0.0.9': '2015-10-19T21:18:13.725Z',
    '0.0.10': '2015-10-19T22:18:13.091Z',
    '0.0.11': '2015-11-03T05:03:06.345Z',
    '0.0.12': '2015-11-15T10:10:48.551Z',
    '0.0.13': '2015-12-04T17:16:43.662Z',
    '0.0.14': '2015-12-05T01:40:39.377Z',
    '0.0.15': '2015-12-05T05:50:59.226Z',
    '0.0.16': '2015-12-10T12:23:28.722Z',
    '0.0.17': '2015-12-14T19:37:08.400Z',
    '0.0.18': '2015-12-15T12:51:47.990Z',
    '0.0.19': '2015-12-15T18:23:33.077Z',
    '0.0.20': '2015-12-15T20:39:55.357Z',
    '0.0.22': '2016-02-20T00:36:56.908Z',
    '0.0.23': '2016-02-20T01:44:13.897Z',
    '0.0.24': '2016-02-25T17:41:20.619Z',
    '0.0.25': '2016-03-10T02:10:05.410Z',
    '0.0.26': '2016-03-23T00:39:46.402Z',
    '0.0.27': '2016-03-23T22:05:56.538Z',
    '0.0.28': '2016-03-28T22:39:45.766Z',
    '0.0.29': '2016-03-30T18:10:47.060Z',
    '0.0.30': '2016-04-06T22:27:32.015Z',
    '0.0.31': '2016-04-11T18:20:32.677Z' },
    maintainers:
    [ 'angularcore [email protected]',
    'rodyhaddad [email protected]' ],
    description: 'CLI tool for Angular2',
    versions:
    [ '0.0.0',
    '0.0.1',
    '0.0.2',
    '0.0.3',
    '0.0.4',
    '0.0.5',
    '0.0.6',
    '0.0.7',
    '0.0.8',
    '0.0.9',
    '0.0.10',
    '0.0.11',
    '0.0.12',
    '0.0.13',
    '0.0.14',
    '0.0.15',
    '0.0.16',
    '0.0.17',
    '0.0.18',
    '0.0.19',
    '0.0.20',
    '0.0.22',
    '0.0.23',
    '0.0.24',
    '0.0.25',
    '0.0.26',
    '0.0.27',
    '0.0.28',
    '0.0.29',
    '0.0.30',
    '0.0.31' ],
    'dist-tags': { latest: '0.0.31' },
    readmeFilename: 'README.md',
    homepage: 'https://github.com/angular/angular-cli',
    keywords: [],
    repository:
    { type: 'git',
    url: 'git+https://github.com/angular/angular-cli.git' },
    author: 'Angular Authors',
    bugs: { url: 'https://github.com/angular/angular-cli/issues' },
    license: 'MIT',
    contributors:
    [ 'Rody Haddad [email protected] (http://rodyhaddad.com/)',
    'Igor Minar [email protected]' ],
    users: { altrim: true },
    version: '0.0.31',
    main: 'lib/cli/index.js',
    trackingCode: 'UA-8594346-19',
    bin: { ng: './bin/ng' },
    scripts: { test: 'node tests/runner', lint: 'eslint .' },
    engines: { node: '>= 4.1.0' },
    dependencies:
    { broccoli: '^1.0.0-beta.6',
    'broccoli-caching-writer': '^2.2.1',
    'broccoli-concat': '^2.2.0',
    'broccoli-funnel': '^1.0.1',
    'broccoli-merge-trees': '^1.1.1',
    'broccoli-uglify-js': '^0.1.3',
    'broccoli-writer': '^0.1.1',
    chalk: '^1.1.1',
    'ember-cli': '2.4.2',
    exit: '^0.1.2',
    'fs-extra': '^0.26.6',
    leek: '0.0.21',
    lodash: '^4.6.1',
    multidep: '^2.0.0',
    opn: '4.0.1',
    resolve: '^1.1.7',
    shelljs: '^0.6.0',
    'silent-error': '^1.0.0',
    'symlink-or-copy': '^1.0.1',
    typescript: '^1.8.7',
    typings: '^0.7.9' },
    'ember-addon': { paths: [ './addon/ng2/' ] },
    devDependencies:
    { chai: '^3.5.0',
    'clang-format': '^1.0.37',
    eslint: '^2.4.0',
    'exists-sync': '0.0.3',
    glob: '^7.0.3',
    minimatch: '^3.0.0',
    mocha: '^2.4.5',
    'object-assign': '^4.0.1',
    rewire: '^2.5.1',
    sinon: '^1.17.3',
    through: '^2.3.8',
    tslint: '^3.6.0',
    'walk-sync': '^0.2.6' },
    gitHead: 'c4897647781f57829cc264d63ca8beecdf79f132',
    dist:
    { shasum: 'f75f78640d1b7cb8e335996768b87ace70fe82c7',
    tarball: 'https://registry.npmjs.org/angular-cli/-/angular-cli-0.0.31.tgz' },
    directories: {} }

  3. Repro steps. Upon

  4. project creation by 'ng new myproj', no custom changes

  5. commit to git repo

  6. the following clone on another machine is missing the 'typings' folder.

  7. npm install produces the error for postinstall step: "typings install --ambient"

  8. which is resulting in missing typings and following 'ng build' error.

  9. ng build gives the error:
    "no such file or directory" typings

Once new typings installed globally, the bug could not be not replicated on same machine. But we had this issue as on OSX and on Win10.

  1. The fix is simple update of typings revision to current (I used 0.7.12 instead of rendered 0.6.6). New typings npm code does not render the error and creates typings folder with content as desired.

I could create the pull request if it helps.
-suns

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions