Skip to content

Critical dependency: the request of a dependency is an expression #2359

Closed
@delasteve

Description

@delasteve
  1. OS? Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
    macOS El Capitan

  2. Versions. Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

    angular-cli: 1.0.0-beta.15
    node: 6.4.0
    os: darwin x64
    
  3. Repro steps. Was this an app that wasn't created using the CLI? What change did you
    do on your code? etc.
    ng new testapp
    cd testapp
    ng test

  4. The log given by the failure. Normally this include a stack trace and some
    more information.

    WARNING in ./~/@angular/core/src/linker/system_js_ng_module_factory_loader.js
    45:15 Critical dependency: the request of a dependency is an expression
    
    WARNING in ./~/@angular/core/src/linker/system_js_ng_module_factory_loader.js
    57:15 Critical dependency: the request of a dependency is an expression
    
  5. Mention any other details that might be useful.
    I believe this is the fix for it. Webpack Warning in system_js_ng_module_factory_loader.js angular#11580 (comment)
    The warning only happens while running ng test but not when doing ng build or ng serve

Metadata

Metadata

Assignees

No one assigned

    Labels

    P5The team acknowledges the request but does not plan to address it, it remains open for discussioneffort1: easy (hours)help wanted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions