Skip to content

Fix prettier setup for repo #14939

Closed
@vikerman

Description

@vikerman

Currently there are unsolved problems with prettier. The big ones being

  • PRs don't pass prettier check in CI if the PR is not exactly one commit on top of master(This can be fixed)
  • Code reviews are messed up because unrelated lines are formatted and pollute the PR and impossible for reviewer to focus on the actual change
  • Messes up history/blame pretty quickly if PR changes unrelated lines

Till we figure out an precise prettier format that formats only changed lines we should disable it.

Joey is going to be looking at common formatting solution across various Angular projects.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions