ng serve does not respect deleteOutputPath option in build target

[filipesilva]

🐞 Bug report

Command (mark with an x)

- [ ] new
- [ ] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

Yes, the previous version in which this bug was not present was: 7

Description

`ng serve` will not respect the `deleteOutputPath` option in its `browserTarget`. The project output path should be deleted if this option is set to `true` (which is the default).

🔬 Minimal Reproduction

ng new dist-project
ng build
ng serve

🔥 Exception or Error

No error. dist/dist-project remains after ng serve, but it should have been deleted.

🌍 Your Environment

Angular CLI: 8.0.1
Node: 12.3.1
OS: win32 x64
Angular: 8.0.0
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.800.1
@angular-devkit/build-angular     0.800.1
@angular-devkit/build-optimizer   0.800.1
@angular-devkit/build-webpack     0.800.1
@angular-devkit/core              8.0.1
@angular-devkit/schematics        8.0.1
@angular/cli                      8.0.1
@ngtools/webpack                  8.0.1
@schematics/angular               8.0.1
@schematics/update                0.800.1
rxjs                              6.4.0
typescript                        3.4.5
webpack                           4.30.0

Anything else relevant?
Reported by @gkalpak :D

[filipesilva]

We initially added this feature to make it clear that if you do ng build and afterwards ng serve, the contents of dist/ were not what was being served. Instead, ng serve is serving content in memory.

But we tried to trace the code for this and it looks like ng serve hasn't been deleting the dist folder for a while. Since 6 or so. And we haven't really heard people having the original problem. So it sounds ok to just left it be as is.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}