Angular6 upgrade: Module not found issue with typescript.js

[pharindoko]

Bug Report or Feature Request (mark with an x)

- [x ] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [x ] serve

Versions

v8.11.3 Same error with solution on Win 10 , Ubuntu 16.04

Repro steps

ng serve

The log given by the failure

Hash: 1d5efd42cf718a0d5c35
[1] Time: 22911ms
[1] chunk {main} main.js, main.js.map (main) 241 kB [initial] [rendered]
[1] chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 677 kB [initial] [rendered]
[1] chunk {runtime} runtime.js, runtime.js.map (runtime) 5.22 kB [entry] [rendered]
[1] chunk {scripts} scripts.js, scripts.js.map (scripts) 940 kB [rendered]
[1] chunk {styles} styles.js, styles.js.map (styles) 199 kB [initial] [rendered]
[1] chunk {vendor} vendor.js, vendor.js.map (vendor) 12.7 MB [initial] [rendered]
[1]
[1] WARNING in ./node_modules/source-map-support/source-map-support.js
[1] Module not found: Error: Can't resolve 'fs' in 'D:\tmp\ngDynamicDashboardDemo\node_modules\source-map-support'
[1]
[1] WARNING in ./node_modules/source-map-support/source-map-support.js
[1] Module not found: Error: Can't resolve 'module' in 'D:\tmp\ngDynamicDashboardDemo\node_modules\source-map-support'
[1]
[1] ERROR in ./node_modules/typescript/lib/typescript.js
[1] Module not found: Error: Can't resolve 'crypto' in 'D:\tmp\ngDynamicDashboardDemo\node_modules\typescript\lib'

Desired functionality

Should serve the cli solution without an error.
This happens after upgrade to Angular 6.0.9 from 5.2.x

Mention any other details that might be useful

This happens after upgrade from Angular 5.2.x to Angular 6.0.9

[alan-agius4]

Have you tried removing the node_modules and doing a fresh npm install?

is not gonna work look at this https://stackoverflow.com/questions/51216526/error-when-using-tensorflow-tfjs-in-angular-6-project

[pharindoko]

Hey thanks for the replies,

to make it more clear what I already did ...

• Update as describe here -> Update Guide Angular.io
• delete node_modules
• npm clean cache -f
• npm verify cache
• npm install
• checked version of typescript (2.7.2)
• npm install --save crypto
• tried to use @angular/cli "^6.1.0-rc.3" as I thought this might fix the problem

In Nodemodules\typescript\lib\typescript.js
line 4348 it has a dependency to crypto and I think this is the issue

            var _crypto = require("crypto");

What kinda strange - another project I migrated to Angular 6 works on the same machine.
I compared both projects but couldn`t find the difference
(angular.json, package.json, tsconfig.json, tslint.json)

@George35mk 👍 Thanks for the workaround. I will try it.

But my clear intention why I opened this issue is, that it is still an ongoing issue and not solved in anyway.
I would hope that someone could make it easier to detect what`s wrong when these error message come up.

[filipesilva]

Heya, you can read more about why fs and crypto do not work anymore in #9827 (comment).

[jslegers]

@filipesilva :

Basically, this means that any library that contains stuff like if (ENVIRONMENT_IS_NODE) { var fs = require("fs"); }; is no longer compatible with Angular 6, right?

Basically, this means that any library that supports both browser & Node is no longer compatible with Angular 6, right?

If not, what am I missing here?

Can I get libraries that do use stuff like if (ENVIRONMENT_IS_NODE) { var fs = require("fs"); }; to work with Angular 6?

And if so, how would I need to do that?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}