Skip to content

feat(uiSref): add support for transition options #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(uiSref): add support for transition options #789

wants to merge 1 commit into from

Conversation

roryf
Copy link

@roryf roryf commented Jan 20, 2014

Allows optionally spcifying options to be passed to $state.go:

<a ui-sref="contacts.detail({id: contact.id}, {reload: true})">

will translate to

$state.go('contacts.detail', {id: contact.id}, {reload: true});

This does somewhat muddy the syntax between the ui-sref attribute and $state.go. Wondered whether a ui-sref-options attribute might be a better implementation?

<a ui-sref="contacts.detail({id: contact.id})" ui-sref-options="{reload: true}">

Allows optionally spcifying options to be passed to $state.go:
<a ui-sref="contacts.detail({id: contact.id}, {reload: true})">
@roryf
Copy link
Author

roryf commented Jan 20, 2014

Just realised this is basically the same as #644 and #628. Failed at the first hurdle: check existing issues...

@roryf
Copy link
Author

roryf commented Jan 20, 2014

and #694.

@nateabele
Copy link
Contributor

Yeah, we're gonna go with the other implementation with the separate attribute. Thanks though!

@nateabele nateabele closed this Jan 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants