Skip to content

Made strings.ts noImplicitAny compliant #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/common/strings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,20 @@ export function kebobString(camelCase: string) {
.replace(/([A-Z])/g, $1 => "-" + $1.toLowerCase()); // replace rest
}

function _toJson(obj) {
function _toJson(obj: Object) {
return JSON.stringify(obj);
}

function _fromJson(json) {
function _fromJson(json: string) {
return isString(json) ? JSON.parse(json) : json;
}


function promiseToString(p) {
function promiseToString(p: Promise<any>) {
return `Promise(${JSON.stringify(p)})`;
}

export function functionToString(fn) {
export function functionToString(fn: Function) {
let fnStr = fnToString(fn);
let namedFunctionMatch = fnStr.match(/^(function [^ ]+\([^)]*\))/);
return namedFunctionMatch ? namedFunctionMatch[1] : fnStr;
Expand All @@ -71,18 +71,18 @@ let stringifyPattern = pattern([
[not(isDefined), val("undefined")],
[isNull, val("null")],
[isPromise, promiseToString],
[isTransitionRejectionPromise, x => x._transitionRejection.toString()],
[isTransitionRejectionPromise, (x: any) => x._transitionRejection.toString()],
[is(Rejection), invoke("toString")],
[is(Transition), invoke("toString")],
[is(Resolvable), invoke("toString")],
[isInjectable, functionToString],
[val(true), identity]
]);

export function stringify(o) {
var seen = [];
export function stringify(o: Object) {
var seen: any[] = [];

function format(val) {
function format(val: any) {
if (isObject(val)) {
if (seen.indexOf(val) !== -1) return '[circular ref]';
seen.push(val);
Expand All @@ -94,7 +94,7 @@ export function stringify(o) {
}

/** Returns a function that splits a string on a character or substring */
export const beforeAfterSubstr = char => str => {
export const beforeAfterSubstr = (char: string) => (str: string) => {
if (!str) return ["", ""];
let idx = str.indexOf(char);
if (idx === -1) return [str, ""];
Expand Down