Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Properly apply right alignment when appendTo is used #5667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vasilak
Copy link

@vasilak vasilak commented Mar 21, 2016

When appendTo is used and the dropdown is right-aligned the positioning is off
because it is calculated relative to the window instead of the specified container.

When appendTo is used and the dropdown is right-aligned the positioning is off
because it is calculated relative to the window instead of the specified container.
@icfantv
Copy link
Contributor

icfantv commented Mar 21, 2016

@RobJacobs, can you review this please? Thanks.

@RobJacobs
Copy link
Contributor

@vasilak Having a plunk demonstrating the problem is extremely helpful to us. That being said, I created a demo plunk here that uncovers another issue with the append-to element alignment - the top alignment is off. In the dropdown scope.$watch('isOpen' function we could do some refactoring to call the $position.positionElements better (with the proper alignment) to take care of this issue and potentially implement auto positioning. I'll create a PR for this shortly.

@icfantv
Copy link
Contributor

icfantv commented Mar 22, 2016

Apologies - I should have asked @vasilak to adhere to the issue template. In the future, please do not summarily delete the template because you don't want to go through the work required. The template is there to make helping you faster. As a result, @RobJacobs had to put forth the time to figure out what was going on here.

In the future, issues entered that do not adhere to the template that are believed by the enterer to be bugs will be closed without further action.

@vasilak
Copy link
Author

vasilak commented Mar 22, 2016

Sorry guys, you 're right.
I will make sure to adhere to the template in the future.

@RobJacobs RobJacobs self-assigned this Mar 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants