Feature/restricted range #638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 950 970 +20
=====================================
+ Hits 950 970 +20
Continue to review full report at Codecov.
|
ValentinH
reviewed
Jun 29, 2018
src/rzslider.js
Outdated
| this.ticks = jElem | ||
| break | ||
| } | ||
| }, | ||
| this | ||
| ) | ||
|
|
||
| // Initialize position cache properties | ||
| this.selBar.rzsp = 0 |
There was a problem hiding this comment.
Why did you remove this part?
|
ALso, I check the fiddle: https://jsfiddle.net/2hxm9cop/1/. Why is the restricted color not red? |
|
Apologies, I messed up while squashing the old branch. Thanks for reviewing with attention! |
|
Perfect! Releasing it right now at 6.6.0 :) |
|
Done 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #583 (comment) (made new clean branch)