feat($compile): adds labelOverlapSeparator as an option #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The labelOverlapSeparator option allows the user to specify what string to use to separate the labels when they overlap. The previous hardcoded string ' - ' could indeed be mistaken as a minus sign. To avoid introducing a breaking change, the default is the previous value: ' - '. Tests and README.md modified accordingly.
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 949 949
=====================================
Hits 949 949
Continue to review full report at Codecov.
|
ValentinH
requested changes
Feb 6, 2018
|
I have removed the file, would it be a good idea to add it to .gitignore ? |
|
Indeed, can you add this as well? :) |
|
Perfect! |
ValentinH
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The labelOverlapSeparator option allows the user to specify what string to use to separate the
labels when they overlap. The previous hardcoded string ' - ' could indeed be mistaken as a minus
sign. To avoid introducing a breaking change, the default is the previous value: ' - '. Tests and
README.md modified accordingly.
Demo: http://jsfiddle.net/sLxkwv9s/
(Compare to original problem: http://jsfiddle.net/04sr3ty0/1/)