Skip to content

Update the labels on separation #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Conversation

ku
Copy link
Contributor

@ku ku commented Feb 16, 2017

When mergeRangeLabelsIfSame is set to true, two labels are combined once their values got close.
They got separated again if the values got away enough, but the text of a label stays the same with old one which is shown when it was combined.

Following gif shows the problem described above.
timeslot

This patch solves the problem by updating the labels on separating combined labels.

@codecov-io
Copy link

codecov-io commented Feb 16, 2017

Codecov Report

Merging #502 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #502   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         932    934    +2     
=====================================
+ Hits          932    934    +2
Impacted Files Coverage Δ
src/rzslider.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7fb91...275ce3f. Read the comment docs.

@ValentinH
Copy link
Member

Sorry for the delay, I haven't found the time to merge it for now (I want to merge and release it in the same time that's why). I'll try to do it soon. 😄

@ValentinH ValentinH merged commit e97cf74 into angular-slider:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants