Skip to content

feat(ticks): Refactor ticks to improve flexibility #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2016

Conversation

ValentinH
Copy link
Member

@ValentinH ValentinH commented Oct 8, 2016

Now it uses transform and explicit positioning. The goal is to add an option that would enable a user to precisely position slider ticks. It also adds a ticksArray option that takes an array of values that should be marked with a tick.

Demo: http://jsfiddle.net/ghjqt6ge/

To do:

  • tests
  • add an option to display ticks under the slider like when showTicksValues > 1

@codecov-io
Copy link

codecov-io commented Oct 8, 2016

Current coverage is 100% (diff: 100%)

Merging #426 into master will not change coverage

@@           master   #426   diff @@
====================================
  Files           1      1          
  Lines         862    869     +7   
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
+ Hits          862    869     +7   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update edf62b0...5ebe436

@ValentinH ValentinH merged commit 9aca352 into master Oct 16, 2016
@ValentinH ValentinH deleted the feature/ticks-v2 branch October 16, 2016 13:41
ValentinH added a commit that referenced this pull request Oct 16, 2016
feat(ticks): Refactor ticks to improve flexibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants