Added the option for having fixed label to the directive #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #405 diff @@
====================================
Files 1 1
Lines 852 854 +2
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 852 854 +2
Misses 0 0
Partials 0 0
|
|
Please describe the purpose of this PR and provide a demo. |
|
This PR is to configure the directive so the limit labels don't hide when we reach a particular limit towards floor or ceil value. |
|
Hi Valentin, Thanks in advance |
| @@ -1093,8 +1096,10 @@ | |||
| backgroundColor: pointercolor | |||
| }; | |||
| } | |||
|
|
|||
| this.shFloorCeil(); | |||
| if(!this.optionsshowLimitLabels){ | |||
|
I'm sorry, I'm currently on holidays so I don't have access to my computer and won't be able to release it anyway... Here are a few remarks:
|
|
Done! |
|
The dist file is still incorrect, you should run grunt before commiting... |
|
Done! |
|
Merged and released under 5.5.0. I have just rename the new option to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If possible please merge it to 5.4.3 as we have started using that version of yours.
Please kindly approve