Hide floor/ceil label when overlapped on combo label

[Liooo]

Fixes #356

Working fiddle

[codecov-io]

Current coverage is 100%

Merging #357 into master will not change coverage

@@           master   #357   diff @@
====================================
  Files           1      1          
  Lines         806    811     +5   
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
+ Hits          806    811     +5   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last updated by d543e52...47792d9

[ValentinH]

Thanks for taking care of that!
I think you can remove the cmbLabelShown property because it's never read.
Also, it will be good to add a test case covering this bug. If you want, I can point you the place the do it ;)

[ValentinH]

For the unit test, you can add a case in this file: https://github.com/angular-slider/angularjs-slider/blob/master/tests/specs/labels-test.js

[Liooo]

cmbLabelShown is actually used here ;)

in order to test this case accurately, we need to take care of viewport size actually I think. The ideal test scenario is to ensure the floor/ceil label is hidden when

• max/min label element is hidden and combo label is shown
• max/min label element (which is invisible) IS NOT overlapping the floor/ceil label
• cmb label element IS overlapping the floor/ceil label

, which is not that easy to setup. Possibly we could set the phantomjs's viewport size before test setup and get the translate function to return the "correct" length string.

The added test sets translation that returns loong string and expect cmb label to be hidden. But the same test also passes in the previous library version, because min/max label elements overlap floor/ceil labels either way.

(same thing applies to any label tests where the handle is located at middle, precisely speaking)

[ValentinH]

My bad, I was on mobile this morning and miss it and also the unit test you added :)

[ValentinH]

LGTM 👍