Skip to content

Remove unnecessary dependency #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2015
Merged

Remove unnecessary dependency #128

merged 1 commit into from
Sep 23, 2015

Conversation

a-tarasyuk
Copy link

After release 0.1.31 appeared error

Uncaught Error: Cannot find module "underscore"

@ValentinH
Copy link
Member

You are right. I don't know why @e-cloud added it... Maybe because of the throttle function but @rzajac added it in the code base to remove the underscore dependency.

ValentinH added a commit that referenced this pull request Sep 23, 2015
Remove unnecessary dependency
@ValentinH ValentinH merged commit c32155e into angular-slider:master Sep 23, 2015
@a-tarasyuk
Copy link
Author

@ValentinH could you update version from 0.1.31 to 0.1.32 ?

@ValentinH
Copy link
Member

it's done. Tell me if it's ok for you please ;)

@a-tarasyuk
Copy link
Author

For me works fine. Thank you very much.

@e-cloud
Copy link
Contributor

e-cloud commented Sep 24, 2015

@a-tarasyuk , i'm so sorry, in my local dev, i tried to use underscore to do some other thing. And afterward i gave it up. but the code's clean-up was not thorough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants