-
-
Notifications
You must be signed in to change notification settings - Fork 497
TypeScript: Invalid module name in augmentation - rzslider.d.ts #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This library doesn't support Angular 2+. See #549 (comment) . Looking at other Hope this helps. |
Thanks for reply and solution. We have hybrid application with AgularJS 1.5 and Angular 5 and angularjs-slider is used only in AngularJS part. But I installed I found my solution there: https://stackoverflow.com/a/42702089 So this is not issue and it can be closed ;-) |
Glad to help. @ValentinH , can you close this? Also, should we update the installation section of the readme to indicate that typescript definitions are included and if using them, there is a peer dependency on |
Yeah sure. Would you like to update the readme ? |
We are upgrading our application from AngularJS 1.5 to Angular 5. With Angular 5, there is TypeScript 2.4. We are building with webpack 3.8.1 and error is:
Error:(6, 16) TS2665:Invalid module name in augmentation. Module 'angular' resolves to an untyped module at /node_modules/angular/index.js', which cannot be augmented.
We have angularjs-slider 6.4.0.
Steps to reproduce
Expected behaviour
It is possible to fix this by moving angular import into module declaration in rzslider.d.ts:
Actual behaviour
Actually, angular import is outside module declaration in rzslider.d.ts:
The text was updated successfully, but these errors were encountered: