Skip to content

Vendor prefix for transform #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bod1ka opened this issue Mar 27, 2017 · 8 comments
Closed

Vendor prefix for transform #516

bod1ka opened this issue Mar 27, 2017 · 8 comments

Comments

@bod1ka
Copy link
Contributor

bod1ka commented Mar 27, 2017

Steps to reproduce

  1. Use some browser that requires vendor prefix for transform property
  2. Use vertical slider with ticks

Demo: http://jsfiddle.net/yra7skru/1/

Expected behaviour

All ticks being aligned correctly

Actual behaviour

Ticks being squashed

@ValentinH
Copy link
Member

What browser has an issue? Because we have prefix for old browsers but maybe not that old: https://github.com/angular-slider/angularjs-slider/blob/master/dist/rzslider.css#L242

@bod1ka
Copy link
Contributor Author

bod1ka commented Mar 28, 2017

Safari 600.1.4 on iPad
Not sure how this line in css could help with the issue.
There is a line https://github.com/angular-slider/angularjs-slider/blob/master/dist/rzslider.js#L993 where the transform property is set dynamically.
So I suppose prefixes should also be added there.

@bod1ka
Copy link
Contributor Author

bod1ka commented Mar 28, 2017

You could even open this page with examples on this browser and see the issues with vertical ticks
http://angular-slider.github.io/angularjs-slider/index.html

@ValentinH
Copy link
Member

Sorry I forgot this part of the code. I thought a PR already submitted a fix for this, I don't remember why it wasn't merged...

@ValentinH
Copy link
Member

OK that was the issue: #472

I have tried to fix that but noticed that this was handled directly by ng-style so I couldn't manually add the prefixes...

@bod1ka
Copy link
Contributor Author

bod1ka commented Mar 28, 2017

I have checked the source code for ng-style.
It doesn't do anything with prefixes , it just calls jqlite css method.
Which doesn't remove them either.
To simplify all it does is:

  • Convert name to camelCase ('-webkit-transform' becomes 'webkitTransform')
  • Set style for element using rawDomElement.style[property]

So the suggested fix in #472 will work

@ValentinH
Copy link
Member

Could you provide a pull request for this?

@ValentinH
Copy link
Member

Fixed in 6.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants