-
-
Notifications
You must be signed in to change notification settings - Fork 497
Fix tick placement for some legacy browsers #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes why not. I have also used a PostCSS plugin to prefix all the stuff that can be integrated in the Grunt pipeline. It might be easier to maintain don't you think? |
Automatic prefixing sounds like a win to me. In either case we also need to modify the transform style that we're adding in updateTicksScale() to include prefixes. |
Indeed, I forgot the |
Fix released via 5.8.9 |
Tell me if it fixes your issue. I wasn't able to add prefix to the |
Hmm...unfortunately
Which seems to do the job. |
That's weird because when I tried that, ng-style was simply adding the 'transform' property without the prefixed version? Does this mean that it depends on the browser where it gets executed? |
Some legacy browsers do not position tick labels correctly because they require the prefixed version of the transform rule but otherwise work fine. My primary target is Chrome 34 because some folks still use it for NPAPI support. I propose adding a mixin that automatically adds all the prefixed transform rules for us.
I've forked, made the change, and tested. Good to open a PR?
The text was updated successfully, but these errors were encountered: