Skip to content

maxRange option not applied with pushRange #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GuilloOme opened this issue Nov 7, 2016 · 4 comments
Closed

maxRange option not applied with pushRange #453

GuilloOme opened this issue Nov 7, 2016 · 4 comments
Labels
bug

Comments

@GuilloOme
Copy link
Contributor

Demo: http://jsfiddle.net/sh49nvLs/

Steps to reproduce

move the right slider to the right: in one case, it's "blocked" in the other case, nothing append.

Expected behaviour

We would expect the other handle to follow the first one.
@ValentinH
Copy link
Member

Well spotted, this is a bug...

@ValentinH ValentinH added the bug label Nov 8, 2016
@GuilloOme
Copy link
Contributor Author

It looks like it's missing some this.options.maxRange logic in applyPushRange()

@ValentinH
Copy link
Member

Actually, I think that applyMinMaxRange should be called after this line.

GuilloOme added a commit to GuilloOme/angularjs-slider that referenced this issue Nov 8, 2016
@GuilloOme
fix(change in function applyPushRange()): Apply the pushRange when th…
20a6461 
…e difference is greater than th

Apply the pushRange when the difference is greater than the maxRange set

Close issue angular-slider#453
GuilloOme added a commit to GuilloOme/angularjs-slider that referenced this issue Nov 8, 2016
@GuilloOme
fix(applyPushRange): Apply the pushRange with maxRange
bcd36f9 
Apply the pushRange when the difference is greater than the maxRange set

Close issue angular-slider#453
@GuilloOme GuilloOme mentioned this issue Nov 8, 2016
Merged
ValentinH pushed a commit that referenced this issue Nov 8, 2016
@GuilloOme @ValentinH
fix(applyPushRange): Apply the pushRange with maxRange (#456)
6327b88 
Apply the pushRange when the difference is greater than the maxRange set

Close issue #453
@ValentinH
Copy link
Member

Fixed in 5.8.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuilloOme @ValentinH