Skip to content

maxRange option? #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ux-engineer opened this issue May 12, 2016 · 6 comments
Closed

maxRange option? #322

ux-engineer opened this issue May 12, 2016 · 6 comments

Comments

@ux-engineer
Copy link

It seems you have not implemented maxRange option...is there a way to achieve this by hooking into some event or so?

@ValentinH
Copy link
Member

Indeed this isn't implemented but could be added quite easily, just need to mimic to minRange behaviour. If you want you can submit a PR and I can guide you if needed.

@ux-engineer
Copy link
Author

@ValentinH I tried to create a fork for this but I haven't ever written tests for front-end code so this is too complex project for me to hop in out of the blue...

@ValentinH
Copy link
Member

I think there are only a few tests to be added. Just search for 'minRange' in the specs folder, copy/paste those tests and adapt them ;) You can already create a Pull request and I can guide you there.

@ux-engineer
Copy link
Author

How can I test my changes with a browser without building dist files in each turn?

@ValentinH
Copy link
Member

Sorry, I've missed your last answer. I just finished implementing the option...

While developing, you should run grunt watch and everything will be generated automatically.

@ValentinH
Copy link
Member

Implemented in #333 and released under 2.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants