Skip to content

Please can you add a property to bound labels to within the slider #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zebslc opened this issue Nov 23, 2015 · 3 comments
Closed

Please can you add a property to bound labels to within the slider #182

zebslc opened this issue Nov 23, 2015 · 3 comments

Comments

@zebslc
Copy link

zebslc commented Nov 23, 2015

If using bootstrap columns, it is really easy to make the slider translated label appear over the form label or off the edge of the page with anything more than the single percentage labels used in your example.

Please can you add a configuration property that bounds any translated labels within the left and right of the slider (probably default off for performance)

https://jsfiddle.net/jbaggaley/d356L6rL/5/

mobile width
label overwrite

Thank you :-)

@ValentinH
Copy link
Member

I totally agree and I don't think it should be with an attribute: labels should be inside the slider bounds.

There is the #135 PR that tries to do it, but there is still a few bugs...

@zebslc
Copy link
Author

zebslc commented Nov 23, 2015

cool - sorry I didn't notice this! Feel free to use fiddle as part of test..

Thank you! 😄

@ValentinH
Copy link
Member

Actually the PR was ready but needed rebasing. Since I had no news from its author, I added his code myself to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants