fix: reactive forms not updating on changes in store #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @GenZodd small diff based on your initial support. Could you please have a look? |
kuhnroyal
force-pushed
the
master
branch
4 times, most recently
from
d81d07e to
196e598
Compare
Signed-off-by: Peter Leibiger <[email protected]>
smithad15
approved these changes
Jan 21, 2018
|
Published as part of v6.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes reactive forms not updating on changes in store data. Writing changes to the store works.
They don't have a parent
NgForm, so the update never gets triggered.Additionally
NgForm.updateModelcan not be called since it is noNgForm.Now using the
FormControl.setValuefunction uniformly instead.