Skip to content

native-federation builder i18n bug #404

Closed
@refactorTractor

Description

@refactorTractor

Hi!

I made a fork of one of your examples here and tried adding i18n. Aside from solving a minor problem, that buildTarget in extract-i18n had to be modified to directly refer to the esbuild config, I think I found a bug if i18n is supported from your side.

My build fails with the following call stack:

[error] Error: ENOENT: no such file or directory, open 'D:\work\temp\module-federation-plugin-example\dist\shell\index.html'
    at Object.openSync (node:fs:600:3)
    at Object.readFileSync (node:fs:468:35)
    at updateIndexHtml (D:\work\temp\module-federation-plugin-example\node_modules\@angular-architects\native-federation\src\utils\updateIndexHtml.js:16:27)
    at runBuilder_1 (D:\work\temp\module-federation-plugin-example\node_modules\@angular-architects\native-federation\src\builders\build\builder.js:108:59)

It's no suprise. With i18n turned on, the dist folder no longer contains an index.html, that is now in the language bundles' folders.

Has support for i18n been thought through also in the regards that shell and mfe builds of corresponding languages will have to 'meet'? Is that just a matter of where they are hosted relative to each other / what their baseHref is?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions