Skip to content

Conversation

@jooohhn
Copy link
Contributor

@jooohhn jooohhn commented Apr 26, 2021

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

@jooohhn jooohhn requested a review from ajhorst April 26, 2021 06:45
Copy link
Contributor

@kelvin-lu kelvin-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after the console removals.

Do you have plans to add unit tests to this?

@jooohhn jooohhn force-pushed the fix-cleanup-test-cookies branch from 083a00c to 1d85a3d Compare April 30, 2021 16:52
@jooohhn jooohhn merged commit 9d8ecc3 into main Apr 30, 2021
@jooohhn jooohhn deleted the fix-cleanup-test-cookies branch April 30, 2021 16:53
github-actions bot pushed a commit that referenced this pull request Apr 30, 2021
## [8.2.1](v8.2.0...v8.2.1) (2021-04-30)

### Bug Fixes

*  Cleanup test cookies ([#381](#381)) ([9d8ecc3](9d8ecc3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Amplitude is adding too many cookies causing 400 Bad Request errors

4 participants