Skip to content

Conversation

muka
Copy link
Contributor

@muka muka commented Nov 3, 2020

  • store config in yaml
  • expose ice servers

This should be good to close #34

- store config in yaml
@pep8speaks
Copy link

pep8speaks commented Nov 3, 2020

Hello @muka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-03 05:24:25 UTC

@commit-lint
Copy link

commit-lint bot commented Nov 3, 2020

Contributors

@muka

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@ivelin
Copy link
Contributor

ivelin commented Nov 3, 2020

Very cool, @muka !

Would you like to add a section to README with a reference example to peerjs-config.yaml ?

@muka
Copy link
Contributor Author

muka commented Nov 4, 2020

You are right, will add the config sample in the docs

@ivelin
Copy link
Contributor

ivelin commented Nov 9, 2020

Merging this one so its not dangling. Let's do the docs update as a separate PR.

@ivelin ivelin merged commit c1cf754 into ambianic:master Nov 9, 2020
ivelin pushed a commit that referenced this pull request Nov 9, 2020
# [1.4.0](v1.3.0...v1.4.0) (2020-11-09)

### Features

* expose dedicated configuration ([c1cf754](c1cf754)), closes [#37](#37)
@ivelin
Copy link
Contributor

ivelin commented Nov 9, 2020

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ivelin ivelin added the released label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ICE server config outside of python code to a config file
3 participants