Skip to content

Dropdown component improvements #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbezhanov
Copy link

@mbezhanov mbezhanov commented Jul 12, 2017

This PR proposes 2 improvements to the Dropdown component:

  1. The ability to specify fluid Dropdowns
  2. Respond to "click" events instead of "focus" events, when selecting Dropdown items, and stop event propagation, in order to avoid conflicts with Modal component (this screenshot explains the reason behind this - if the Dropdown options overlap with the Modal dimmer, when trying to select the option, the Modal closes)

Used both in a project of mine. If you think it's appropriate, please consider accepting this PR. If any additional work is necessary on my end - let me know.

@mbezhanov mbezhanov changed the title Fluid Dropdowns Dropdown component improvements Jul 13, 2017
@almino almino added this to the Fluid Dropdown milestone Sep 25, 2017
@almino
Copy link
Owner

almino commented Sep 25, 2017

First of all, sorry for not responding in a while. I had an accident and broke my elbow and femur. My left arm will be limited for a long time.

  1. Sorry, I forgot that.

  2. The click event has problem when I'm using Search Selection Dropdown. We have to work around this.

@almino
Copy link
Owner

almino commented Sep 25, 2017

I'm working on Multi Select Dropdown. When it make the master branch, it will include fluid attribute.

I'll try the @click.stop event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants