-
Notifications
You must be signed in to change notification settings - Fork 11
Added menu components #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning to accept menu items as a prop.
Submenu could have a header prop.
Since the framework's name is Semantic UI, I would like to have classes ordered in a semantic way.
I'll find a way to accept your codes changes at the develop branch and make little tweaks. When it becomes master, I'll include you profile link on contributors.
Hi, I'll check that. By the way, do you plan do implement javascript modules? Such as dropdown, popup, sidebar, tabs, etc.? I'll need all of these for a project I'm working on, maybe we can split the job. Do you consider using semantic JS library (with jquery as dependency) or re-write everything without jquery? |
The goal is not to use jQuery at all. Right now, I'm working on Dropdown and DatePicker. There's a popup example on my DatePicker.vue. |
Hey, I've added menu collection components, based on your code structure and following official semantic-ui doc (https://semantic-ui.com/collections/menu.html)