Skip to content

Added menu components #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Added menu components #1

wants to merge 12 commits into from

Conversation

renoguyon
Copy link

Hey, I've added menu collection components, based on your code structure and following official semantic-ui doc (https://semantic-ui.com/collections/menu.html)

Copy link
Owner

@almino almino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to accept menu items as a prop.
Submenu could have a header prop.
Since the framework's name is Semantic UI, I would like to have classes ordered in a semantic way.

I'll find a way to accept your codes changes at the develop branch and make little tweaks. When it becomes master, I'll include you profile link on contributors.

@renoguyon
Copy link
Author

Hi,

I'll check that. By the way, do you plan do implement javascript modules? Such as dropdown, popup, sidebar, tabs, etc.?

I'll need all of these for a project I'm working on, maybe we can split the job. Do you consider using semantic JS library (with jquery as dependency) or re-write everything without jquery?

@almino almino changed the base branch from master to develop May 23, 2017 20:43
@almino
Copy link
Owner

almino commented May 23, 2017

The goal is not to use jQuery at all.

Right now, I'm working on Dropdown and DatePicker.

There's a popup example on my DatePicker.vue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants