Skip to content

Commit 894ae77

Browse files
committed
mute verbose messages
1 parent 960c603 commit 894ae77

File tree

3 files changed

+33
-23
lines changed

3 files changed

+33
-23
lines changed

afy/predictor_remote.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from arguments import opt
22
from networking import SerializingContext, check_connection
3-
from utils import Tee, TicToc, AccumDict, Once
3+
from utils import Logger, TicToc, AccumDict, Once
44

55
import multiprocessing as mp
66
import queue
@@ -25,7 +25,7 @@ def __init__(self, *args, in_addr=None, out_addr=None, **kwargs):
2525
self.out_addr = out_addr
2626
self.predictor_args = (args, kwargs)
2727
self.timing = AccumDict()
28-
self.log = Tee('./var/log/predictor_remote.log')
28+
self.log = Logger('./var/log/predictor_remote.log', verbose=opt.verbose)
2929

3030
self.send_queue = mp.Queue(QUEUE_SIZE)
3131
self.recv_queue = mp.Queue(QUEUE_SIZE)
@@ -88,8 +88,7 @@ def _send_recv_async(self, method, args, critical):
8888
'id': self._i_msg
8989
}
9090

91-
if opt.verbose:
92-
self.log("send", meta)
91+
self.log("send", meta)
9392

9493
if critical:
9594
self.send_queue.put((meta, data))
@@ -111,8 +110,7 @@ def _send_recv_async(self, method, args, critical):
111110
self.log('recv_queue is empty')
112111
return None
113112

114-
if opt.verbose:
115-
self.log("recv", meta_recv)
113+
self.log("recv", meta_recv)
116114

117115
tt.tic()
118116
if meta_recv['name'] == 'predict':
@@ -128,7 +126,7 @@ def _send_recv_async(self, method, args, critical):
128126
@staticmethod
129127
def send_worker(address, send_queue, worker_alive):
130128
timing = AccumDict()
131-
log = Tee('./var/log/send_worker.log')
129+
log = Logger('./var/log/send_worker.log', opt.verbose)
132130

133131
ctx = SerializingContext()
134132
sender = ctx.socket(zmq.PUSH)
@@ -163,7 +161,7 @@ def send_worker(address, send_queue, worker_alive):
163161
@staticmethod
164162
def recv_worker(address, recv_queue, worker_alive):
165163
timing = AccumDict()
166-
log = Tee('./var/log/recv_worker.log')
164+
log = Logger('./var/log/recv_worker.log')
167165

168166
ctx = SerializingContext()
169167
receiver = ctx.socket(zmq.PULL)

afy/predictor_worker.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from predictor_local import PredictorLocal
22
from arguments import opt
33
from networking import SerializingContext, check_connection
4-
from utils import Tee, TicToc, AccumDict, Once
4+
from utils import Logger, TicToc, AccumDict, Once
55

66
import cv2
77
import numpy as np
@@ -58,14 +58,14 @@ def run(self):
5858
@staticmethod
5959
def recv_worker(port, recv_queue, worker_alive):
6060
timing = AccumDict()
61-
log = Tee('./var/log/recv_worker.log')
61+
log = Logger('./var/log/recv_worker.log', verbose=opt.verbose)
6262

6363
ctx = SerializingContext()
6464
socket = ctx.socket(zmq.PULL)
6565
socket.bind(f"tcp://*:{port}")
6666
socket.RCVTIMEO = RECV_TIMEOUT
6767

68-
log(f'Receiving on port {port}')
68+
log(f'Receiving on port {port}', important=True)
6969

7070
try:
7171
while worker_alive.value:
@@ -92,17 +92,17 @@ def recv_worker(port, recv_queue, worker_alive):
9292

9393
Once(timing, log, per=1)
9494
except KeyboardInterrupt:
95-
log("recv_worker: user interrupt")
95+
log("recv_worker: user interrupt", important=True)
9696

9797
worker_alive.value = 0
98-
log("recv_worker exit")
98+
log("recv_worker exit", important=True)
9999

100100
@staticmethod
101101
def predictor_worker(recv_queue, send_queue, worker_alive):
102102
predictor = None
103103
predictor_args = ()
104104
timing = AccumDict()
105-
log = Tee('./var/log/predictor_worker.log')
105+
log = Logger('./var/log/predictor_worker.log', verbose=opt.verbose)
106106

107107
try:
108108
while worker_alive.value:
@@ -129,7 +129,7 @@ def predictor_worker(recv_queue, send_queue, worker_alive):
129129
args = msgpack.unpackb(data)
130130
timing.add('UNPACK', tt.toc())
131131
except ValueError:
132-
log("Invalid Message")
132+
log("Invalid Message", important=True)
133133
continue
134134

135135
tt.tic()
@@ -142,7 +142,7 @@ def predictor_worker(recv_queue, send_queue, worker_alive):
142142
del predictor
143143
predictor_args = args
144144
predictor = PredictorLocal(*predictor_args[0], **predictor_args[1])
145-
log("Initialized predictor with:", predictor_args)
145+
log("Initialized predictor with:", predictor_args, important=True)
146146
result = True
147147
tt.tic() # don't account for init
148148
elif method['name'] == 'predict':
@@ -172,24 +172,24 @@ def predictor_worker(recv_queue, send_queue, worker_alive):
172172

173173
Once(timing, log, per=1)
174174
except KeyboardInterrupt:
175-
log("predictor_worker: user interrupt")
175+
log("predictor_worker: user interrupt", important=True)
176176
except Exception as e:
177-
log("predictor_worker error")
177+
log("predictor_worker error", important=True)
178178
traceback.print_exc()
179179

180180
worker_alive.value = 0
181-
log("predictor_worker exit")
181+
log("predictor_worker exit", important=True)
182182

183183
@staticmethod
184184
def send_worker(port, send_queue, worker_alive):
185185
timing = AccumDict()
186-
log = Tee('./var/log/send_worker.log')
186+
log = Logger('./var/log/send_worker.log', verbose=opt.verbose)
187187

188188
ctx = SerializingContext()
189189
socket = ctx.socket(zmq.PUSH)
190190
socket.bind(f"tcp://*:{port}")
191191

192-
log(f'Sending on port {port}')
192+
log(f'Sending on port {port}', important=True)
193193

194194
try:
195195
while worker_alive.value:
@@ -215,10 +215,10 @@ def send_worker(port, send_queue, worker_alive):
215215

216216
Once(timing, log, per=1)
217217
except KeyboardInterrupt:
218-
log("predictor_worker: user interrupt")
218+
log("predictor_worker: user interrupt", important=True)
219219

220220
worker_alive.value = 0
221-
log("send_worker exit")
221+
log("send_worker exit", important=True)
222222

223223

224224
def run_worker(in_port=None, out_port=None):

afy/utils.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,18 @@ def flush(self):
3434
self.file.flush()
3535

3636

37+
class Logger():
38+
def __init__(self, filename, verbose=True):
39+
self.tee = Tee(filename)
40+
self.verbose = verbose
41+
42+
def __call__(self, *args, important=False, **kwargs):
43+
if not self.verbose and not important:
44+
return
45+
46+
self.tee(*args, **kwargs)
47+
48+
3749
class Once():
3850
_id = {}
3951

0 commit comments

Comments
 (0)