fix(ulimit): complete limits only after option that takes one

Author: scop

completions/ulimit

@@ -32,12 +32,7 @@ _ulimit()
         fi
     fi
 
-    [[ $prev == -[SH] ]] && return
-
-    local args
-    _count_args
-    ((args == 1)) &&
-        COMPREPLY=($(compgen -W "soft hard unlimited" -- "$cur"))
+    [[ ${mode-} ]] && COMPREPLY=($(compgen -W "soft hard unlimited" -- "$cur"))
 } &&
     complete -F _ulimit ulimit
 

test/t/test_ulimit.py

@@ -6,7 +6,7 @@
 class TestUlimit:
     @pytest.mark.complete("ulimit ")
     def test_1(self, completion):
-        assert completion
+        assert not completion
 
     @pytest.mark.complete("ulimit -", require_cmd=True)
     def test_2(self, completion):
@@ -40,3 +40,8 @@ def test_7(self, completion):
     def test_no_special_values_after_soft_or_hard(self, bash, flag):
         completion = assert_complete(bash, "ulimit %s " % flag)
         assert not completion
+
+    @pytest.mark.complete("ulimit -c 0 -n ")
+    def test_special_not_just_first(self, completion):
+        """Test we offer limit values not only for the first option."""
+        assert completion