Extract used prop types detection code #2
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a single spec failing here:
The reason is because
no-unused-prop-types
ignores validation when it finds object spread:https://github.com/yannickcr/eslint-plugin-react/blob/9258d796b2544fcee5980bca3b343e3dc8e7e3a2/lib/rules/no-unused-prop-types.js#L722-L725
Whereas
prop-types
doesn't:https://github.com/yannickcr/eslint-plugin-react/blob/9258d796b2544fcee5980bca3b343e3dc8e7e3a2/lib/rules/prop-types.js#L702-L704
Not sure how to reconcile this.