This repository was archived by the owner on May 14, 2020. It is now read-only.
Remove babel runtime dependency #70
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the usage of
Symbol.iterator
in order to removebabel-runtime
while (hopefully 😄) still supporting IE11.This reduces the package size from 2.3 MB down to only 300 kB.
The PR relies on the fact that iterable objects should have a
.forEach
method. At least that's my intuition, though I'm not an expert on this particular subject.I added tests for the types mentioned in
JSONNode.js
though I couldn't come up with test cases for typeCustom
andIterable
.