Skip to content

Commit fdf984b

Browse files
committed
Remove loops witch never loops fixes rust-ndarray#642
1 parent b1dc684 commit fdf984b

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/dimension/dimension_trait.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,8 @@ pub trait Dimension:
130130
if self.slice().iter().all(|&d| d != 0) {
131131
let mut it = strides.slice_mut().iter_mut().rev();
132132
// Set first element to 1
133-
while let Some(rs) = it.next() {
133+
if let Some(rs) = it.next() {
134134
*rs = 1;
135-
break;
136135
}
137136
let mut cum_prod = 1;
138137
for (rs, dim) in it.zip(self.slice().iter().rev()) {
@@ -156,9 +155,8 @@ pub trait Dimension:
156155
if self.slice().iter().all(|&d| d != 0) {
157156
let mut it = strides.slice_mut().iter_mut();
158157
// Set first element to 1
159-
while let Some(rs) = it.next() {
158+
if let Some(rs) = it.next() {
160159
*rs = 1;
161-
break;
162160
}
163161
let mut cum_prod = 1;
164162
for (rs, dim) in it.zip(self.slice()) {

0 commit comments

Comments
 (0)