fix: new unit test, some name change

Author: 1yam

src/aleph/sdk/client/services/authenticated_port_forwarder.py

@@ -58,7 +58,7 @@ async def _verify_status_processed_and_ownership(
             )
         return message, status
 
-    async def get_ports(
+    async def get_address_ports(
         self, address: Optional[str] = None
     ) -> AggregateConfig[AllForwarders]:
         """
@@ -76,9 +76,9 @@ async def get_ports(
                 raise ValueError("No account provided and client is not authenticated")
             address = self._client.account.get_address()
 
-        return await super().get_ports(address=address)
+        return await super().get_address_ports(address=address)
 
-    async def get_port(
+    async def get_ports(
         self, item_hash: ItemHash = None, address: Optional[str] = None
     ) -> Optional[Ports]:
         """
@@ -100,9 +100,9 @@ async def get_port(
         if item_hash is None:
             raise ValueError("item_hash must be provided")
 
-        return await super().get_port(address=address, item_hash=item_hash)
+        return await super().get_ports(address=address, item_hash=item_hash)
 
-    async def create_port(
+    async def create_ports(
         self, item_hash: ItemHash, ports: Ports
     ) -> Tuple[AggregateMessage, MessageStatus]:
         """
@@ -128,7 +128,7 @@ async def create_port(
             key=self.aggregate_key, content=content
         )
 
-    async def update_port(
+    async def update_ports(
         self, item_hash: ItemHash, ports: Ports
     ) -> Tuple[AggregateMessage, MessageStatus]:
         """
@@ -176,7 +176,7 @@ async def delete_ports(
         # _, _ = await self._verify_status_processed_and_ownership(item_hash=item_hash)
 
         # Get the Port Config of the item_hash
-        port: Optional[Ports] = await self.get_port(item_hash=item_hash)
+        port: Optional[Ports] = await self.get_ports(item_hash=item_hash)
         if not port:
             raise
 

src/aleph/sdk/client/services/crn.py

@@ -40,7 +40,7 @@ async def get_last_crn_version(self):
         """
         # Create a new session for external domain requests
         async with aiohttp.ClientSession() as session:
-            async with session.get(settings.CRN_VERSION) as resp:
+            async with session.get(settings.CRN_VERSION_URL) as resp:
                 resp.raise_for_status()
                 data = await resp.json()
                 return data.get("tag_name")
@@ -133,6 +133,6 @@ async def update_instance_config(self, crn_address: str, item_hash: ItemHash):
         full_url = sanitize_url(crn_address + f"/control/{item_hash}/update")
 
         async with aiohttp.ClientSession() as session:
-            async with session.get(full_url) as resp:
+            async with session.post(full_url) as resp:
                 resp.raise_for_status()
                 return await resp.json()

src/aleph/sdk/conf.py

@@ -87,7 +87,7 @@ class Settings(BaseSettings):
     DNS_API: ClassVar[str] = "https://api.dns.public.aleph.sh/instances/list"
     CRN_URL_UPDATE: ClassVar[str] = "{crn_url}/control/machine/{vm_hash}/update"
     CRN_LIST_URL: ClassVar[str] = "https://crns-list.aleph.sh/crns.json"
-    CRN_VERSION: ClassVar[str] = (
+    CRN_VERSION_URL: ClassVar[str] = (
         "https://api.github.com/repos/aleph-im/aleph-vm/releases/latest"
     )
     SCHEDULER_URL: ClassVar[str] = "https://scheduler.api.aleph.cloud/"