fix: remove aleph credit list

Author: 1yam

src/aleph_client/commands/credit.py

@@ -3,16 +3,13 @@
 from typing import Annotated, Optional
 
 import typer
-from aiohttp import ClientResponseError
 from aleph.sdk import AlephHttpClient
 from aleph.sdk.account import _load_account
 from aleph.sdk.conf import settings
-from aleph.sdk.query.filters import CreditsFilter
 from aleph.sdk.types import AccountFromPrivateKey
 from aleph.sdk.utils import displayable_amount
 from rich.console import Console
 from rich.panel import Panel
-from rich.table import Table
 from rich.text import Text
 
 from aleph_client.commands import help_strings
@@ -68,40 +65,3 @@ async def show(
                 )
     else:
         typer.echo("Error: Please provide either a private key, private key file, or an address.")
-
-
-@app.command(name="list")
-async def list_credits(
-    page_size: Annotated[int, typer.Option(help="Numbers of element per page")] = 100,
-    page: Annotated[int, typer.Option(help="Current Page")] = 1,
-    min_balance: Annotated[
-        Optional[int], typer.Option(help="Minimum balance required to be taken into account")
-    ] = None,
-    json: Annotated[bool, typer.Option(help="Display as json")] = False,
-):
-    try:
-        async with AlephHttpClient(api_server=settings.API_HOST) as client:
-            credit_filter = CreditsFilter(min_balance=min_balance) if min_balance else None
-            filtered_credits = await client.get_credits(credit_filter=credit_filter, page_size=page_size, page=page)
-            if json:
-                typer.echo(filtered_credits.model_dump_json(indent=4))
-            else:
-                table = Table(title="Credits Information", border_style="white")
-                table.add_column("Address", style="bright_cyan")
-                table.add_column("Credits", justify="right", style="bright_cyan")
-
-                for credit in filtered_credits.credit_balances:
-                    table.add_row(credit.address, f"{displayable_amount(credit.credits, decimals=2)}")
-
-                # Add pagination footer
-                pagination_info = Text.assemble(
-                    f"Page: {filtered_credits.pagination_page} of {filtered_credits.pagination_total} | ",
-                    f"Items per page: {filtered_credits.pagination_per_page} | ",
-                    f"Page size: {filtered_credits.pagination_total}",
-                )
-                table.caption = pagination_info
-
-                console.print(table)
-    except ClientResponseError as e:
-        typer.echo("Failed to retrieve credits.")
-        raise (e)

tests/unit/test_credits.py

@@ -5,7 +5,7 @@
 import pytest
 from aiohttp import ClientResponseError
 
-from aleph_client.commands.credit import list_credits, show
+from aleph_client.commands.credit import show
 
 
 @pytest.fixture
@@ -181,115 +181,3 @@ async def run(mock_get):
             )
 
     await run()
-
-
-@pytest.mark.asyncio
-async def test_list_credits_default(mock_credits_list_response, capsys):
-    """Test the list_credits command with default parameters."""
-
-    @patch("aiohttp.ClientSession.get")
-    async def run(mock_get):
-        mock_get.return_value = mock_credits_list_response
-
-        # Run the list_credits command with default parameters
-        await list_credits(
-            page_size=100,
-            page=1,
-            min_balance=None,
-            json=False,
-        )
-
-    await run()
-    captured = capsys.readouterr()
-    assert "Credits Information" in captured.out
-    assert "0x1234567890123456789012345678901234567890" in captured.out
-    # The credits might be displayed in their raw form without formatting
-    assert "1000000000" in captured.out
-
-
-@pytest.mark.asyncio
-async def test_list_credits_with_filter(mock_credits_list_response, capsys):
-    """Test the list_credits command with min_balance filter."""
-
-    @patch("aiohttp.ClientSession.get")
-    async def run(mock_get):
-        mock_get.return_value = mock_credits_list_response
-
-        # Run the list_credits command with min_balance filter
-        await list_credits(
-            page_size=100,
-            page=1,
-            min_balance=1000000,  # 0.01 credits with 8 decimals
-            json=False,
-        )
-
-    await run()
-    captured = capsys.readouterr()
-    assert "Credits Information" in captured.out
-
-
-@pytest.mark.asyncio
-async def test_list_credits_json_output(mock_credits_list_response, capsys):
-    """Test the list_credits command with JSON output."""
-
-    @patch("aiohttp.ClientSession.get")
-    async def run(mock_get):
-        mock_get.return_value = mock_credits_list_response
-
-        # Run the list_credits command with JSON output
-        await list_credits(
-            page_size=100,
-            page=1,
-            min_balance=None,
-            json=True,
-        )
-
-    await run()
-    captured = capsys.readouterr()
-    assert "credit_balances" in captured.out
-    assert "pagination_page" in captured.out
-
-
-@pytest.mark.asyncio
-async def test_list_credits_custom_pagination(mock_credits_list_response):
-    """Test the list_credits command with custom pagination parameters."""
-
-    @patch("aiohttp.ClientSession.get")
-    async def run(mock_get):
-        mock_get.return_value = mock_credits_list_response
-
-        # Run the list_credits command with custom pagination
-        await list_credits(
-            page_size=50,
-            page=2,
-            min_balance=None,
-            json=False,
-        )
-
-        # Verify that the parameters were passed correctly
-        # In the SDK, these parameters are passed as part of the 'params' argument, not in the URL
-        called_params = mock_get.call_args[1]["params"]
-        assert called_params["pagination"] == "50"
-        assert called_params["page"] == "2"
-
-    await run()
-
-
-@pytest.mark.asyncio
-async def test_list_credits_api_error(mock_credit_error_response):
-    """Test the list_credits command handling API errors."""
-
-    @patch("aiohttp.ClientSession.get")
-    async def run(mock_get):
-        mock_get.return_value = mock_credit_error_response
-
-        # Run the list_credits command and expect it to handle the error
-        with pytest.raises(ClientResponseError):
-            await list_credits(
-                page_size=100,
-                page=1,
-                min_balance=None,
-                json=False,
-            )
-
-    await run()