Stackless issue python#265: Fix invalid function cast warnings

Fix invalid function cast warnings with gcc 8 for method conventions
different from METH_NOARGS, METH_O and METH_VARARGS excluding Argument
Clinic generated code.

Author: Anselm Kruis

Stackless/changelog.txt

@@ -9,6 +9,11 @@ What's New in Stackless 3.X.X?
 
 *Release date: 20XX-XX-XX*
 
+- https://github.com/stackless-dev/stackless/issues/265
+  Fix invalid function cast warnings with gcc 8 for method conventions
+  different from METH_NOARGS, METH_O and METH_VARARGS excluding Argument Clinic
+  generated code.
+
 - https://github.com/stackless-dev/stackless/issues/265
   Most (getter)-functions, (setter)-functions and (PyCFunction)-functions with
   flag METH_NOARGS used to lack an unused last argument, "void *" for (getter)

Stackless/module/_teststackless.c

@@ -494,11 +494,11 @@ static PyObject* test_PyEval_EvalFrameEx(PyObject *self, PyObject *args, PyObjec
 static PyMethodDef _teststackless_methods[] = {
     {"softswitchablefunc",             _teststackless_softswitchabledemo,         METH_VARARGS | METH_STACKLESS,
     _teststackless_softswitchabledemo_doc},
-    { "test_cframe", (PyCFunction) test_cframe, METH_VARARGS | METH_KEYWORDS,
+    { "test_cframe", (PyCFunction)(void(*)(void))test_cframe, METH_VARARGS | METH_KEYWORDS,
     test_cframe__doc__ },
     { "test_cstate", (PyCFunction) test_cstate, METH_O,
     test_cstate__doc__ },
-    { "test_PyEval_EvalFrameEx", (PyCFunction) test_PyEval_EvalFrameEx, METH_VARARGS | METH_KEYWORDS,
+    { "test_PyEval_EvalFrameEx", (PyCFunction)(void(*)(void))test_PyEval_EvalFrameEx, METH_VARARGS | METH_KEYWORDS,
     test_PyEval_EvalFrameEx__doc__ },
     {NULL,              NULL}           /* sentinel */
 };

Stackless/module/stacklessmodule.c

@@ -227,8 +227,8 @@ schedule_remove(PyObject *self, PyObject *args, PyObject *kwds);
 static PyObject *
 PyStackless_Schedule_M(PyObject *retval, int remove)
 {
-    PyMethodDef sched = {"schedule", (PyCFunction)schedule, METH_VARARGS|METH_KEYWORDS};
-    PyMethodDef s_rem = {"schedule", (PyCFunction)schedule_remove, METH_VARARGS|METH_KEYWORDS};
+    PyMethodDef sched = {"schedule", (PyCFunction)(void(*)(void))schedule, METH_VARARGS|METH_KEYWORDS};
+    PyMethodDef s_rem = {"schedule", (PyCFunction)(void(*)(void))schedule_remove, METH_VARARGS|METH_KEYWORDS};
     if (remove)
         return PyStackless_CallCMethod_Main(&s_rem, NULL, "O", retval);
     else
@@ -510,7 +510,7 @@ run_watchdog(PyObject *self, PyObject *args, PyObject *kwds);
 static PyObject *
 PyStackless_RunWatchdog_M(long timeout, long flags)
 {
-    PyMethodDef def = {"run", (PyCFunction)run_watchdog, METH_VARARGS | METH_KEYWORDS};
+    PyMethodDef def = {"run", (PyCFunction)(void(*)(void))run_watchdog, METH_VARARGS | METH_KEYWORDS};
     int threadblock, soft, ignore_nesting, totaltimeout;
     threadblock = (flags & Py_WATCHDOG_THREADBLOCK) ? 1 : 0;
     soft =        (flags & PY_WATCHDOG_SOFT) ? 1 : 0;
@@ -1663,11 +1663,11 @@ PyDoc_STRVAR(slpmodule_getthreads__doc__,
 static PyMethodDef stackless_methods[] = {
         _STACKLESS_PICKLE_FLAGS_DEFAULT_METHODDEF
         _STACKLESS_PICKLE_FLAGS_METHODDEF
-    {"schedule",                    (PCF)schedule,              METH_KS,
+    {"schedule",                  (PCF)(void(*)(void))schedule, METH_KS,
      schedule__doc__},
-    {"schedule_remove",             (PCF)schedule_remove,       METH_KS,
+    {"schedule_remove",    (PCF)(void(*)(void))schedule_remove, METH_KS,
      schedule__doc__},
-    {"run",                         (PCF)run_watchdog,          METH_VARARGS | METH_KEYWORDS,
+    {"run",                   (PCF)(void(*)(void))run_watchdog, METH_VARARGS | METH_KEYWORDS,
      run_watchdog__doc__},
     {"getruncount",                 (PCF)getruncount,           METH_NOARGS,
      getruncount__doc__},
@@ -1679,9 +1679,9 @@ static PyMethodDef stackless_methods[] = {
      getmain__doc__},
     {"enable_softswitch",           (PCF)enable_softswitch,     METH_O,
      enable_soft__doc__},
-    {"_test_cframe_nr",              (PCF)_test_cframe_nr,        METH_VARARGS | METH_KEYWORDS,
+    {"_test_cframe_nr",    (PCF)(void(*)(void))_test_cframe_nr, METH_VARARGS | METH_KEYWORDS,
     _test_cframe_nr__doc__},
-    {"_test_outside",                (PCF)_test_outside,          METH_NOARGS,
+    {"_test_outside",                (PCF)_test_outside,        METH_NOARGS,
     _test_outside__doc__},
     {"set_channel_callback",        (PCF)set_channel_callback,  METH_O,
      set_channel_callback__doc__},

Stackless/module/taskletobject.c

@@ -1414,7 +1414,7 @@ static PyObject *
 PyTasklet_Throw_M(PyTaskletObject *self, int pending, PyObject *exc,
                            PyObject *val, PyObject *tb)
 {
-    PyMethodDef def = {"throw", (PyCFunction)tasklet_throw, METH_VARARGS|METH_KEYWORDS};
+    PyMethodDef def = {"throw", (PyCFunction)(void(*)(void))tasklet_throw, METH_VARARGS|METH_KEYWORDS};
     if (!val)
         val = Py_None;
     if (!tb)
@@ -2574,15 +2574,15 @@ static PyMethodDef tasklet_methods[] = {
      tasklet_set_atomic__doc__},
     {"set_ignore_nesting", (PCF)tasklet_set_ignore_nesting, METH_O,
      tasklet_set_ignore_nesting__doc__},
-    {"throw",                   (PCF)tasklet_throw,         METH_KS,
+    {"throw",            (PCF)(void(*)(void))tasklet_throw, METH_KS,
     tasklet_throw__doc__},
-    {"raise_exception",         (PCF)tasklet_raise_exception, METH_VS,
+    {"raise_exception",       (PCF)tasklet_raise_exception, METH_VS,
     tasklet_raise_exception__doc__},
-    {"kill",                    (PCF)tasklet_kill,          METH_KS,
+    {"kill",              (PCF)(void(*)(void))tasklet_kill, METH_KS,
      tasklet_kill__doc__},
-    {"bind",                    (PCF)tasklet_bind,          METH_VARARGS | METH_KEYWORDS,
+    {"bind",              (PCF)(void(*)(void))tasklet_bind, METH_VARARGS | METH_KEYWORDS,
      tasklet_bind__doc__},
-    {"setup",                   (PCF)tasklet_setup,         METH_VARARGS | METH_KEYWORDS,
+    {"setup",            (PCF)(void(*)(void))tasklet_setup, METH_VARARGS | METH_KEYWORDS,
      tasklet_setup__doc__},
     {"__reduce__",              (PCF)tasklet_reduce,        METH_NOARGS,
      tasklet_reduce__doc__},
@@ -2592,7 +2592,7 @@ static PyMethodDef tasklet_methods[] = {
      tasklet_setstate__doc__},
     {"bind_thread",              (PCF)tasklet_bind_thread,  METH_VARARGS,
     tasklet_bind_thread__doc__},
-    {"context_run", (PCF)tasklet_context_run, METH_FASTCALL | METH_KEYWORDS | METH_STACKLESS,
+    {"context_run", (PCF)(void(*)(void))tasklet_context_run, METH_FASTCALL | METH_KEYWORDS | METH_STACKLESS,
             tasklet_context_run__doc__},
     _STACKLESS_TASKLET_SET_CONTEXT_METHODDEF
     {NULL,     NULL}             /* sentinel */

Stackless/pickling/prickelpit.c

@@ -144,7 +144,7 @@ _wrap_clear(PyObject *ob)
 static PyMethodDef prefix##_methods[] = { \
     {"__reduce__",     (PyCFunction)reduce,             METH_NOARGS,    NULL}, \
     {"__setstate__",   (PyCFunction)setstate,           METH_O,         NULL}, \
-    {"__new__",            (PyCFunction)_new_wrapper,   METH_VARARGS | METH_KEYWORDS, \
+    {"__new__",        (PyCFunction)(void(*)(void))_new_wrapper, METH_VARARGS | METH_KEYWORDS, \
      PyDoc_STR("wwwwwaaaaaT.__new__(S, ...) -> " \
                "a new object with type S, a subtype of T")}, \
     {NULL, NULL} \
@@ -289,7 +289,7 @@ unwrap_frame_arg(PyObject * args) {
 }
 
 static struct PyMethodDef _new_methoddef[] = {
-    {"__new__", (PyCFunction)_new_wrapper, METH_VARARGS | METH_KEYWORDS,
+    {"__new__", (PyCFunction)(void(*)(void))_new_wrapper, METH_VARARGS | METH_KEYWORDS,
      PyDoc_STR("T.__new__(S, ...) -> "
                "a new object with type S, a subtype of T.__base__")},
     {0}