Skip to content

Finalized implementing channel specific settings #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

gosha305
Copy link
Contributor

@gosha305 gosha305 commented Mar 20, 2025

  • I agree to license my contribution under GPL-3.0 and agree to allow distribution on app stores as outlined in LICENSE-APPSTORE

To test this pull request, follow the instructions in the wiki.


Combines implementation of channel specific category selections from #1372 (for the popup UI) and #1261. Thank you to both @zedseven and @scaccoman, as I likely wouldn't have even attempted this were it not for their previous work.

Additional minor changes also include:

  • Slightly modifying the popup UI in order to account for other languages having longer skip option and category names
  • Changing the inherit option's name to global in order to clearly convey that it uses the option selected in the global config
  • Adding a clarification of what the currently selected global option is, in parentheses

currently selected global option in parentheses

  • Adding a delete channel settings button in the popup (otherwise, the settings are only deleted if their category selections are empty)

delete channel settings button

Finally, removes the whitelist system entirely. Instead, existing whitelists are converted to have all non-disabled categories at Show overlay in the channel settings.

Also see ajayyy/ExtensionTranslations#81

@gosha305 gosha305 force-pushed the channel-specific-settings branch from cea3a4e to bc8ed34 Compare March 20, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants