Skip to content

Commit 42be95f

Browse files
author
Frankie Bromage
committed
reformat according to standards
1 parent 9313f6d commit 42be95f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

airbyte_cdk/destinations/vector_db_based/document_processor.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import json
66
import logging
77
from dataclasses import dataclass
8-
from typing import Any, Dict, List, Mapping, Optional, Tuple
8+
from typing import Any, Dict, List, Mapping, Optional, Tuple, Union
99

1010
import dpath
1111
from airbyte_cdk.destinations.vector_db_based.config import (
@@ -163,14 +163,14 @@ def _generate_document(self, record: AirbyteRecordMessage) -> Optional[Document]
163163
relevant_fields = self._extract_relevant_fields(record, self.text_fields)
164164
if len(relevant_fields) == 0:
165165
return None
166-
if self.omit_field_names_from_embeddings == False:
166+
if not self.omit_field_names_from_embeddings:
167167
text = stringify_dict(relevant_fields)
168168
else:
169169
text = self._extract_values_from_dict(relevant_fields)
170170
metadata = self._extract_metadata(record)
171171
return Document(page_content=text, metadata=metadata)
172172

173-
def _extract_values_from_dict(self, data):
173+
def _extract_values_from_dict(self, data: Union[dict, list, Any]) -> str:
174174
if isinstance(data, dict):
175175
return "\n".join(self._extract_values_from_dict(value) for value in data.values())
176176
elif isinstance(data, list):

unit_tests/destinations/vector_db_based/document_processor_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ def test_complex_text_fields():
213213
"_ab_stream": "namespace1_stream1",
214214
}
215215

216+
216217
def test_complex_text_fields_omit_field_names():
217218
processor = initialize_processor()
218219

@@ -262,6 +263,7 @@ def test_complex_text_fields_omit_field_names():
262263
"_ab_stream": "namespace1_stream1",
263264
}
264265

266+
265267
def test_no_text_fields():
266268
processor = initialize_processor()
267269

0 commit comments

Comments
 (0)